fix(bulk): enable running bulk loader with only gql schema #8903
+288
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
requested review from
meghalims,
sanjayk-github-dev,
harshil-goel,
all-seeing-code,
billprovince and
joshua-goldstein
as code owners
dgraph-bot
added
area/testing
mangalaman93
force-pushed
the
aman/bulk
branch
3 times, most recently
from
96adccf to
b67af59
Compare
all-seeing-code
previously approved these changes
Jul 12, 2023
If only gql schema is provided, and DQL schema is missing bulk loader used to fail. This PR adds the ability to auto generate the DQL schema from the gql schema and use it in the bulk loader. This PR also adds support for running bulk loader in the dgraphtest package.
all-seeing-code
approved these changes
Jul 12, 2023
harshil-goel
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If only gql schema is provided, and DQL schema is missing bulk loader used to fail. This PR adds the ability to auto generate the DQL schema from the gql schema and use it in the bulk loader.
This PR also adds support for running bulk loader in the dgraphtest package. Additionally, this PR also changes the dgraphtest package to always copy the dgraph binary into a temp folder even when the version of the dgraph used is set to "local".
Closes: DGRAPHCORE-324
Docs PR: NA